Don't try to change the icon of the "sort" action menu
Review Request #109966 - Created April 11, 2013 and submitted
When changing the sorting through the "sort" action menu, dolphin will try to change the icon. However this change fails and just removes the icon. In my opinion there is no need at all to change the icon, it should always stay the same (it can be changed by the user with the kde tool bar editor btw.).
Thanks for the patch! I see that the code in question has been added in http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=76258ddc9c3cb037b70ea2a060608ae4e397ae88 which originates in a review request by Todd: https://svn.reviewboard.kde.org/r/3862/ @Todd: can you comment on this?
Thanks for the new patch! Looks reasonable, but I wonder why this could be an issue for the "view_mode" menu at all? The only situation in which this would become a problem is when there is a view mode without icon, right? I'm OK with this being committed to KDE/4.10 (except for the "view_mode" changes, unless there is a very good reason to change it that I'm overlooking). If I shall do it for you, please let me know. Well, there is actually a small problem left: Imagine you have set icons for the "Sort by" menu and for "Sort by Date", but not for "Sort by Name". When you switch to sorting by date, the menu's icon will be changed, but it does not change back when you switch to "Sort by Name". But I don't see a straightforward way to fix this right now, and I guess it's a rather unlikely corner case anyway.