This fixes the cluttering of tabs after pinned tabs are unpinned!
Review Request #109854 - Created April 4, 2013 and discarded
Just changed the position of setTabData(false); in the function unpinTab() to a position similar as in pinTab()
Tests done and it works fine!!
Are you kidding?? You just NOT moved setTabData call. You also commented out something else and you broke the whole slot. Again, your code is broken and your tests are not enough. And this is a 3 lines of code patch. Mayank, are you planning to improve your attention and the quality of your patches or thinking to continue this way? How do you think I can feel seeing your next review request coming?
Review request changed
ooh... I finally understood the problem you were referring! Your code anyway contains anyway some traces from the previous discarded patch. In example you are yet trying to pin JUST the currentIndex() tab, while the feature is intended to work on ALL tabs you right click to. A proper fix (at least I hope so) for this is to right-calculate the "availableIndex". commit f619f0769ae049 tries to.