Sort email addresses in main list by TLD first, then domain, and only last by account name

Review Request #109847 - Created April 3, 2013 and updated

Information
Thomas Fischer
kgpg
278376
Reviewers
kdeutils
Sort email addresses in main list by TLD first, then domain, and only last by account name.
(1) email address is split along @ and .
(2a) list is reversed
(2b) list elements are joined, two elements separated by .

  
Rolf Eike Beer
Thomas Fischer
Rolf Eike Beer
Thomas Fischer
Thomas Fischer
Commit Hook
Thomas Fischer
Thomas Fischer
Thomas Fischer
Review request changed

Change Summary:

> I wonder what happens to emails like foo.bar@example.com with TLDfirst, the
> regex will split them into foo, bar, example, com AFAICT, which would screw
> up sorting, no?
I rewrote this case, should work better now, too.
The patch contains some minor rewrites for the other cases as well plus some unifications in the white spaces.

> For an unknown reason the items added in the ui file are ignored, they only 
> appear when added again in C++.
No idea either.

> When the setting is changed and Accept or OK is clicked keysmanager will not
> refresh it's display. You should probably call something like invalidateFilter
> on the filter model used for the main view.
Observed as well. How do I trigger such a refresh/invalidation? The settings/options class do no see the model (or the view) directly as far as I can see...

Diff:

Revision 5 (+39 -25)

Show changes

Loading...