adds shortcuts for clone, pin and detach in the tabbar.
Review Request #109808 - Created March 31, 2013 and discarded
Just additions to the action set in tabwidget.cpp!
tested and runs well! Just icons for pintab and clonetab, cant find it!
Mayank, it's 12 lines of code patch and there are 3 errors (explained) and 2 missing important things: 1) why do you need these shortcuts? why did you decide for those shortcuts? Other browsers have them? People is used to? Are them free shortcuts or are used somewhere else for some other things? 2) just adding to tabwidget the actions and adding the shortcuts will let it work just... the shortcuts! You HAVE to reimplement those action (eg: in the tabbar) using the NEW actions you added. Last, I'm curious about your tests. How can it "runs well" if the called pinTab slot not even exist (at least not in the tabwidget)?
Ok, you fixed first step. Now: 1) how did you choose new shortcuts? Are them used somewhere else? Why didn't you choose to just add them to the tabwidget (listing them in the shortcut configuration dialog) and then leaving nothing as default shortcut? 2) what about e.g. the code in tabbar::contextMenu slot? If you implement such actions in tabwidget you should check all rekonq code to call them when used.
Review request changed
I'm sorry but I finally realized these actions cannot have shortcuts. In fact the shortcut can be applied just to the "default" case that is the tab is the current one, while these actions can be applied to whatever tab (just right click over a not selected tab to understand)