Support custom providers in the GHNS upload dialog
Review Request #109421 - Created March 11, 2013 and submitted
The download dialog correctly takes a custom providers .xml file, as can be specified in the .knsrc file, into account; however the upload dialog just ignored this option until now. This patch intends to fix that behavior. Nothing should change if you don't have a custom ProvidersUrl= in your .knsrc file.
The new provider is correctly being listed in the dropdown list of the first page of the dialog. If the custom provider is selected, the program tries to establish a connection to that provider. However, I could not test it any further because I don't have a working provider server... yet.
One thing which came to my mind while I further worked on this, should the custom providers be added to the list, or replace it? I.e., if I have custom providers listed, should the default ones still be displayed or not?
Looks good to me. I would think the default providers should only be listed if they are also in the new providers file. Otherwise it's impossible to set your application to not use the default provider.
Review request changed
Hey Jeremy, cool, thanks. The patch I proposed doesn't do that, it just adds the provider file to the default files. I agree though that the better behavior would be only to show the new file then. Since I'm not entirely sure if I did that correctly, I'll update the patch once more -- if you don't see a problem with it, should I just push it to kdelibs master? Cheers, Sven
Revision 2 (+65 -47)