Do not skip rows in Details View when scrolling by clicking the empty area of the scroll bar

Review Request #109210 - Created Feb. 28, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
KDE/4.10
315619
Reviewers
dolphin
Currently, the view is scrolled up or down by its height when the empty area of the scroll bar is clicked. However, this height includes the height of the header widget in Details View. Therefore, we skip a row when scrolling up or down.

I propose to not just use "view->size().height()" in KItemListController to determine the scroll bar's "pageStep", but to use a new member function of KItemListView which takes the possible header widget into account.
Works.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Wouldn't viewport()->height() be simpler? (it could replace the whole method, I would think) David Faure David Faure
Commit Hook
Frank Reininghaus
Review request changed

Status: Closed (submitted)

David Faure

   
Wouldn't viewport()->height() be simpler?

(it could replace the whole method, I would think)
Loading...