search&replace, project: show header in results
Review Request #109159 - Created Feb. 25, 2013 and submitted
This patch actually does 3 things: 1) it adds property projectName() and projectBaseDir() to the project plugin, so those can be queried from the outside, and the name etc. can be shown there (needed for the 3rd point) 2) it makes the one column of the results tree view use the whole width by setting stretchLastColumn to true, and remove the resizeColumnToContent() call. Personally I like that better. 3) it adds a header to the treewidget which shows "Results in folder <search dir>" or "Result in project <name>" depending on the search mode. A stylesheet is used to make it bold black on white. This feels a bit hardcoded. I can commit those things also separately. Alex
1) I think these are useful additions. A NOTIFY would be nice (not needed for the search plugin, but anyways :) This is Christoph's call. 3) I'm not totally happy about loosing still one line of height... The folder/project information is quite important tho. What about adding the folder/project information to the first "file" entry in the tree view. Something like: > some_file.txt: 5 Results in folder /some/folder 2) This makes it a bit more cumbersome to scroll to the end of a long line and without 3) it would be impossible.
Review request changed
This version of the patch now: 1) still the same projectName() and projectBaseDir() properties 2) removed 3) it now uses the HTML stuff you sent me
Revision 2 (+58 -7)