Allow async KAuth Action with helper (and disallow async without helper)

Review Request #109133 - Created Feb. 25, 2013 and submitted

Information
Yichao Yu
kdelibs
KDE/4.10, master
310149
Reviewers
kdelibs
aseigo, dafre, dfaure, ervin
It is async action without helper, instead of with helper, that doesn't make much sense.

http://lists.kde.org/?l=kde-devel&m=135274807824550&w=2
Following pykde4 code doesn't report error and the action is executed successfully (with a valid action_id, helper_id and arguments).

        action = KAuth.Action(action_id)
        action.setHelperID(helper_id)
        action.setArguments(args)
        if hasattr(callback, "__call__"):
            # the new-style signal connecting somehow doesn't work here..
            QObject.connect(action.watcher(),
                            SIGNAL("actionPerformed(const
KAuth::ActionReply&)"),
                            lambda reply: callback(reply.succeeded()))
        action.setExecutesAsync(True)
        reply = action.execute()
        if reply.failed():
            return False
        return True
Yichao Yu
Kevin Ottens
Dario Freddi
Commit Hook
Yichao Yu
Review request changed

Status: Closed (submitted)

Loading...