use plain text for information panel

Reviews
Diff

- Download Diff

Information
Submitter:	Xuetian Weng
Repository:	kde-baseapps
Branch:
Bugs:	262464, 315693
Depends On:
Reviewers
Groups:	dolphin
People:	freininghaus

Description

This is the real fix mentioned in https://git.reviewboard.kde.org/r/108584/ , in this way we can use "real" plain text.

First, use PlainText for label, then change the @info to @label to avoid KLocalizedString add html tag.

(Can this commit to 4.10?)

Testing Done

&, &< &<>, AA<i>BB</i> now all ok.

Thanks for taking care of this issue so quickly! From my point of view, this patch is good for the KDE/4.10 branch, but I guess that this is up to the translators to decide, so I sent a request to their mailing list. Let's wait and see what they say.

Frank Reininghaus Feb. 28, 2013, 8:59 a.m.

Considering that no translators objected so far, I guess that you can push it to KDE/4.10. Thanks!

Luigi Toscano Feb. 28, 2013, 9:49 a.m.

Please wait till tomorrow, or at least after that the tag of 4.10.1 has been created.

If you commit it now, the new string won't be extracted today to gettext templates (scripty, our l10n script, is already running) and translators won't be able to translate it, so the string will be most probably untranslated in 4.10.1. 
Whenever a change affects translations, it should be done at least 25/26 hours before tagging (well, scripty runs in the CET night and the next morning, but just to be sure...).

Frank Reininghaus Feb. 28, 2013, 9:52 a.m.

Thanks Luigi for thinking of this important issue. I agree that it should better wait for 4.10.2 (i.e., commit after 4.10.1 tagging) then!

Xuetian Weng March 13, 2013, 9:11 p.m.
```
shall I commit it now ?
```

Luigi Toscano March 13, 2013, 9:43 p.m.

The tag for 4.10.2 will be on March 28, so yes, please, commit it asap.

Frank Reininghaus March 14, 2013, 11:15 p.m.

As Luigi said, it seems that it should be committed soon, to prevent that we get too close to the 4.10.2 tag. Please go ahead and push to KDE/4.10. Thanks again for your work!

This review has been submitted with commit 914b8d88ae287eda2027c8b638e82184e1df4ed5 by Weng Xuetian to branch KDE/4.10.

You have a pending review.

Review Board 2.5.6.1

Screenshots

Files

Status: Closed (submitted)