rekonq: Actions appear multiple times in custom context menu

Review Request #108888 - Created Feb. 10, 2013 and submitted

Information
Dimitrios Christidis
rekonq
master
Reviewers
rekonq
christidis
When right-clicking on the main toolbar, items "Bookmarks Toolbar" and "Configure Main ToolBar" appear multiple times. To be precise, they appear once for every tab that is currently open.

This bug was introduced in commit 2d8de46a. Each WebWindow creates a new collection, so the loop in MainToolBar::showCustomContextMenu() finds the actions mentioned above multiple times.

I'm attaching a simple diff as a proof-of-concept. Please advise me on what is the correct way to address this issue. Then, I'll create a proper commit patch.

  
Commit Hook
Dimitrios Christidis
Review request changed

Status: Closed (submitted)

Loading...