Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

Review Request #108802 - Created Feb. 6, 2013 and submitted

Information
Dawit Alemayehu
kde-baseapps
origin/master
Reviewers
kde-baseapps
dfaure, freininghaus
This patch fixes DolphinPart such that the "Delete/Move To Trash" actions are automatically toggled if the user presses the Shift key and allows  https://git.reviewboard.kde.org/r/107509/ to be applied.

The code is completely based on what Dolphin's context menu does. Even though this works as planned, I still have reservations about the use of KModifierKeyInfo since every key press event from any application is sent to the application that connects to its signals. In my code and unlike what is done in Dolphin's context menu, I try to mitigate the impact of that by ignoring the signal when the part does not have the focus. Still if there is a better way to capture key press events at the part level I would like to use that instead. Any ideas ?

  

Issues

  • 0
  • 18
  • 3
  • 21
Description From Last Updated
Frank Reininghaus
Dawit Alemayehu
David Faure
Dawit Alemayehu
Dawit Alemayehu
Frank Reininghaus
David Faure
Dawit Alemayehu
Frank Reininghaus
David Faure
Commit Hook
This review has been submitted with commit 8e023ae9e5051cb7b81af86a178e37c1f2c5da94 by Dawit Alemayehu to branch master.
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

Loading...