Make tagging more accessible by keyboard
Review Request #108382 - Created Jan. 13, 2013 and submitted
Make tagging more accessible by keyboard * Pressing "T" will focus the tagedit-box. * The tag is applied by pressing enter. Pressing enter a second time will focus the mainwindow and advance to the next image. * The dropdown of the tagedit-box remembers already entered tags, the order of the dropdown items are sorted such that already entered tags appear first. * add tagging-by-keyboard to "Tips of the day"
I successfully use this feature on a regular basis. Also tested with current HEAD, works fine.
patch not yet tested, but i have a question : You assign T to focus tagsedit view. DO you now that we have already a Tags keyboard shortcuts manager ? What's happen is someone as already created a tag shortcut with 'T' ?
I take a look to your patch (not yet tested) Your new d->assignTagAction is not visible to Tags main menu. It's normal ? It just a cached keyboard shortcut ? Do you see that there is 2 way to manage tags assignment from GUI: 1/ Tags album view from left sidebar 2/ Tags tree view from right sidebar If i'm not too wrong you only manage 2/, to force focus on it. Right ?
Review request changed
The only issue mentioned was the missing documentation visible to the user, therefore I've added the new tagging functionality to "Tips of the day". The patch was also tested by Saurabh. Anything else missing?
Revision 2 (+135 -18)
OK. Sorting is good, the "T" action sounds good. Putting existing tags to the top and the creation of a new tag to the bottom is a decision based on personal preference. The current behavior favors creating new tags, while the patched behavior favors assigning existing tags by keyboard. Gilles, your opinion? Some more questions: - You remove emit currentCompletionTextChanged(current->data...) Why? Unused, causing a bug? - Why setCurrentRow(0)?