Only use parallel sorting when sorting by name

Review Request #108309 - Created Jan. 9, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
KDE/4.10
312679
Reviewers
dolphin
It seems that comparing two dates is less reentrant than it might seem at first sight. In order to prevent crashes and other problems, I propose to only use multiple threads for sorting when sorting by "Name", because naturally comparing strings is the only expensive comparison function.

Does anyone see a problem with this? I really don't want to commit stupid new bugs at this point in the release cycle ;-)
Sorting works OK, verified that it uses only one thread when not sorting by name.
Emmanuel Pescosta
Commit Hook
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...