QueryService: Decouple the SearchRunnables and the Folder class

Review Request #108271 - Created Jan. 8, 2013 and submitted

Information
Vishesh Handa
nepomuk-core
Reviewers
nepomuk
dfaure, sbird
    The SearchRunnable classes used to contain a reference to the Folder and
    call certain functions on it. Since the SearchRunnables were in another
    thread this required mutexes and still often resulted in deadlocks and
    crashes.
    
    The new code uses signals and slots to communicate between the Folder
    and the SearchRunnable classes. This is a lot more elegant and easier to
    understand.

As far as I see the m_runnableMutex is no longer required. Could someone confirm? Or should I just let it be?
Basic functionality testing done. It's a little hard to test the multi-threading part of it.
Simeon Bird
Commit Hook
This review has been submitted with commit add83a0c51a48c5911222e21f67c036bdb13c1df by Vishesh Handa to branch KDE/4.10.
Vishesh Handa
Review request changed

Status: Closed (submitted)

David Faure
Excellent idea.
Loading...