Current Location button for Navigation FloatItem

Review Request #108238 - Created Jan. 7, 2013 and submitted

Information
Mohammed Nafees
marble
master
Reviewers
marble
nienhueser, rahn, renek
http://www.google-melange.com/gci/task/view/google/gci2012/8191206

The home button has been extended in a way which now enables to switch buttons from home button to current location button and vice versa.
yes

Issues

  • 7
  • 0
  • 0
  • 7
Description From Last Updated
lacks the tr() method Torsten Rahn Torsten Rahn
Lacks a tr() method. And an icon (gohome.png IIRC). Torsten Rahn Torsten Rahn
Lacks a tr() method. Torsten Rahn Torsten Rahn
Lacks a tr() method. Torsten Rahn Torsten Rahn
This should be named centerOnCurrentLocation Torsten Rahn Torsten Rahn
"toggle" sounds like this method would show and hide the button depending on multiple calls. I guess it should rather ... Torsten Rahn Torsten Rahn
see above toggleToHomeButton Torsten Rahn Torsten Rahn
Mohammed Nafees
Torsten Rahn
Torsten Rahn
Torsten Rahn
Commit Hook
Mohammed Nafees
Review request changed

Status: Closed (submitted)

Loading...