KStars: fixed code checker issues #2

Review Request #108192 - Created Jan. 5, 2013 and submitted

Information
Mohammed Nafees
kstars
master
Reviewers
kdeedu
krake
http://www.google-melange.com/gci/task/view/google/gci2012/8192207
yes

Issues

  • 6
  • 0
  • 0
  • 6
Description From Last Updated
It might be wise to add a if( !dlg ) return; before each of the delete dlg statements. Akarsh Simha Akarsh Simha
Why is this required? Akarsh Simha Akarsh Simha
Again, the if(...) is not really needed. I think no if( !dlg ) might be needed either. Akarsh Simha Akarsh Simha
if(...) not needed. Just have detailDlg->exec() Akarsh Simha Akarsh Simha
if( ... ) not needed. Just have detailDlg->exec() Akarsh Simha Akarsh Simha
Same Akarsh Simha Akarsh Simha
Akarsh Simha
Kevin Krammer
Kevin Krammer
Commit Hook
Mohammed Nafees
Review request changed

Status: Closed (submitted)

Loading...