KStars: fixed code checker issues #1
Review Request #108166 - Created Jan. 4, 2013 and submitted
built and tested
the value itself seems not to be used. Since both branches for the ifdef use the same function with just different second value, I am wondering if we can't improve on that: // false -> makes kstars slower #define KSTARS_ASSUME_CONVEXITY false and then just (without the #ifdef stuff) drawPolygon(polygon, KSTARS_ASSUME_CONVEXITY);
Please see my note about MAKE_KSTARS_SLOW before shipping it. I'll also request my colleague who wrote that code to check if that's okay.
Shouldn't math.h go below vect.h?
After making this change, check that there are no issues with clipping of the sky polygons, and things like the Milky Way, horizon appear perfectly without problems in all projections. This might be introducing a bug. It is better not to assume that polygons are convex, although it does add some overhead in processing. MAKE_KSTARS_SLOW might make KStars a bit slow, but it might also fix a lot of bugs that we have to otherwise deal with. If you're unsure, I do not recommend making this change.