FileWatch: Do not always add inotify watches for removable media
Review Request #108047 - Created Dec. 31, 2012 and submitted
FileWatch: Do not always add inotify watches for removable media Not everyone wants watches to be added to the removable media. They are okay with loosing tags/ratings and in removable media. Also, certain users do not watch watches ever added for Network Shares - It results in a large amount of network load which is not required. The following options can disable watches in nepomukstrigirc - [RemovableMedia] add watches=true add watches network share=false By default watches are never added to network shares, and they are always added for removable media. BUG: 308474
Not really. I don't have any network shares. I will test it out with a pen-drive later.
Only some notpicking below...
Nitpick: no need to introduce this variable.
Again the code would imho more readable without the additional variable and a single if clause.
This sounds like a good idea. On that note it would be powerful to be able to watch all file resources under a specific parent path using the ResourceWatcher...