Fix Bug 311782 - Directory loading has been cancelled sometimes falsly triggered
Review Request #107787 - Created Dec. 17, 2012 and submitted
Fix Bug 311782 - Directory loading has been cancelled sometimes falsly triggered which was introduced by commit 9dbc24fd647e0457d50ec901d33100c33967be68
"Directory loading has been cancelled" only appears, when the users presses "Stop Loading"
Thanks Emmanuel for the patch! And thanks Kai Uwe for watching out for i18n issues - it seems that the "existing translation" is just not there :-( But now I'm wondering if we need the "Directory loading has been canceled." message at all. If the user clicks the "Stop" button, it's probably sufficient to just clear the status bar's progress text (i.e., m_statusBar->setProgressText(QString()), which we already do now, and also call the status bar's setText(QString) method with an empty string), I think. What do you think?
Thanks Emmanuel, I think that this is the way it should be (at least in the KDE/4.10 branch). When I first read the bug report, I didn't think that we can fix this with a change in just a single line. In fact, my first idea how to solve it would probably have broken other things. Having a group of people discuss about changes in the code really is useful :-) Note that the KDE/4.10 branch is frozen today for RC 1 tagging according to Albert's recent mail, so the push has to wait until tomorrow.