aprs: use external QextSerialPort for TTY reading
Review Request #107536 - Created Nov. 30, 2012 and submitted
|kdewin, marble, release-team|
Instead of embedding an (old) copy of the QextSerialPort library, find for an external one; only if found enable the reading from TTY, which is otherwise disabled (leaving its configuration tab disabled). The drop of the internal QextSerialPort should also fix all the portability issues, since the plugin itself does not use any OS-dependent API, and it is then reenabled unconditionally. Hence, bug 241125 should now be fixed, and bug 237931 and bug 242039 should not happen anymore. @release-team: yes, I know this would introduce a new optional dependency, but on the other hand a copy of a 3rd party library would go away. Would this be acceptable at this point?
The Aprs plugin compiles fine with and without an external QextSerialPort library.
Off-topic: This patch reminds me that this ext serial port usage should msot likely be gone altogether in the near future in favour of QtSerialPort we developed for Qt4 and Qt5 in open, but that is for later.
Review request changed
Looks good to me, but I can't test it really lacking suitable hardware. I added Wes (plugin's author) as a reviewer explicitly to get him notified about it.
Tjanks a lot Pino for your latest great Marble patches. This patch looks like a good idea to solve the QExtSerialDevice issue (And lazlo is right that in the future we should move to or offer parallel support for QSerialPort :-)). Hm, actually we should enable this aprs plugin by default :)