KML random <colorMode> functionality
Review Request #107478 - Created Nov. 26, 2012 and submitted
added the KML random <colorMode> functionality according to the KML specifications
yes, testing done
|Shouldn't red be d->m_randomColor.redF(), and likewise for green, blue?||Dennis Nienhüser|
Great work and welcome to the "real" Marble development :-)
"paintColor()" sounds like a method that would do the actual painting. So maybe this should be called paintedColor() instead.
This looks overly complex to me. Why not just do the whole method in three lines of code: d->m_randomColor.setRedF(color().redF()*(qrand()/(qreal)RAND_MAX)); d->m_randomColor.setGreenF(color().greenF()*(qrand()/(qreal)RAND_MAX)); d->m_randomColor.setBlueF(color().blueF()*(qrand()/(qreal)RAND_MAX));
Review request changed
changed paintColor() to paintedColor() as suggested by Torsten.
Revision 2 (+70 -11)