Fix bookmarks "Recently Accessed" and "Search for" not available with default install
Review Request #107464 - Created Nov. 25, 2012 and submitted
|freininghaus, ppenz, vhanda|
The bookmarks for "Recently Accessed" and "Search for" is not available in dolphin after a default install, since git rev. f5b6fbf7 https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/f5b6fbf7747cefceef4bcd31d90d053da5c560c4 With a default install, indexing is enabled by default and [Service-nepomukfileindexer]autostart is not written in nepomukserverrc. https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/nepomuk/kcm/nepomukserverkcm.cpp#L216 Because in dolphin, placesitemmodel.cpp line 93 m_fileIndexingEnabled = config.group("Service-nepomukfileindexer").readEntry("autostart", false) default to false if [Service-nepomukfileindexer]autostart is missing, m_fileIndexingEnabled is false by default even if indexing is available. m_fileIndexingEnabled should follow the default value (true) of nepomukserverkcm m_checkEnableFileIndexer. The suggested patch fixes this issue. regards, Luc Menut - Mageia PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.
tested with KDE 4.9.80 (Mageia Cauldron)
Thanks Luc for debugging this! In principle, I would say that this makes sense. However, I've just tried "grep Service-nepomukfileindexer * -r" in my KDE source directory and found quite a few places in Dolphin and kdelibs where this might need to be changed as well. But keeping that default value 'true' in so many different places looks very inconvenient from a maintenance point of view to me. Isn't there a better solution for this? I must admit that I'm not too familiar with KConfig* - in Dolphin, we auto-generate the settings classes from *.kcfg files, which have default values in them which can be used everywhere. This might not be be best approach for the Nepomuk settings, but I'm still wondering if we can avoid hard-coding the default value in so many different files. Moreover, I'm quite puzzled that this hasn't been reported earlier. If this is broken since f5b6fbf7, this means that this has *never* worked because that commit was before the first stable release which contains the new Places Panel.