Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

Review Request #107032 - Created Oct. 25, 2012 and submitted

Information
Milian Wolff
kdelibs
KDE/4.10, master
Reviewers
kdelibs
dfaure
When KServiceTypeTrader::createInstanceFromQuery fails in KService::createInstance, the error message is currently overwritten by the useless information "No service matching the requirements was found". This patch fixes that to keep the error message set by KService::createInstance and thus give me something more useful like e.g. "Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevqmljslanguagesupport.so: (libqtc-qmlsupport.so: cannot open shared object file: No such file or directory)" ' 
changed the header, ran KDevelop with invalid plugins, got actually useful output (see above). Another example that was overwritten as well before this patch:

"Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: (/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: undefined symbol: _ZTIN8KDevelop17ITemplateProviderE)" ' 
David Faure
Commit Hook
This review has been submitted with commit c78c13973ab47a79dc0a515fb891d6328808344f by Milian Wolff to branch KDE/4.10.
Milian Wolff
Review request changed

Status: Closed (submitted)

Loading...