Make Find a toggle action
Review Request #107016 - Created Oct. 23, 2012 and discarded
I was working in the placesview when I noticed that the Find is not a toggle button. Pushing many times the Find button resulted in "nothing" and I expected it to "disable" the search mode, as it happens with Split, or Preview. The patch is pretty straight forward.
I think that was once done to make it consistent with eg. the filter bar which also is opened and then has a close button. When it is a toggle action, this should make it possible to get rid of that annoying close button in the Find bar? What do you think?
What about consistency with other KDE and non-KDE applications? like kate, okular, konqueror, rekonq, calligra, firefox, google-chrome, gedit? I actually can't immediately think of one application using "toggle find" except konsole, but konsole has stopped doing that in the master code (https://git.reviewboard.kde.org/r/105723/). Maybe should add usability team into this review ?