Port Dolphin from Nepomuk to Nepomuk2
Review Request #106825 - Created Oct. 13, 2012 and submitted
Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
|NepomukCore_Found, not Nepomuk_FOUND||Vishesh Handa|
|No longer required||Vishesh Handa|
|I don't think this file is required any more. The ResourceWatcher is now provided in NepomukCore. You guys don't need ...||Vishesh Handa|
|Please get rid of this header and source file. NepomukCore now provides the resourcewatcher.||Vishesh Handa|
If you don't mind i would just say that i tested the patch, and with it the 'Additional information' within the view does not pickup the data from Nepomuk. Info panel's OK. Also, one is not able to enable the info with the patch. This is off course fixed with replacing all occurrences of NepomukFOUND with NepomukCore_FOUND in dolphin/src/CMakeLists.txt
I guess my script isn't that great. Once you have made the changes, please try doing a fresh build of Dolphin to see if everything is okay.
NepomukCore_Found, not Nepomuk_FOUND
Blank line. Please remove
No longer required
I don't think this file is required any more. The ResourceWatcher is now provided in NepomukCore. You guys don't need a copy of it.
Please get rid of this header and source file. NepomukCore now provides the resourcewatcher.
Review request changed
Updated the patch ;) I did a fresh build and everything worked fine for me.