Prevent button action from enabling disabled DPMS

Review Request #106794 - Created Oct. 11, 2012 and submitted

Information
Oliver Henshaw
kde-workspace
4.8, 4.9, master
Reviewers
solid
Prevent button action from enabling disabled DPMS

Button actions call triggerImpl, which leaves DPMS enabled. It can't be
disabled until return from idle, as that would wake the screen. Solve
this by explicitly setting DPMS timeouts to zero when DPMS is meant to
be disabled - i.e. when unloading the action or when screen power
management is inhibited.

CCBUG: 295164
(in combination with review request  #106793 )

Set power button to "Turn off screen" then press it, wait for the screen to turn off then wake the system from idle. Check 'xset -q' has expected values in various situations, e.g.:

- when timed screen power saving is enabled
- when it's disabled
- when it hasn't been enabled in this login
- when screen power saving is inhibited
- when profile or configuration or activity change
- when profile or configuration or activity change when screen power saving is inhibited

I think this covers all cases, but please hammer away with it and see if you can find any problems I've missed.
Oliver Henshaw
Dario Freddi
Commit Hook
Commit Hook
This review has been submitted with commit d91dfc6eab74a31f9f3525bc83be95c373b014e6 by Oliver Henshaw to branch master.
Oliver Henshaw
Review request changed

Status: Closed (submitted)

Loading...