KActivities support on Ark

Review Request #106612 - Created Sept. 27, 2012 and discarded

Information
Tomaz Canabrava
ark
Reviewers
kdeutils
ivan
Adds support for KActivities on ark.
This review request is done by my student, on the KDE Internship program. more will come.
monitored the activity database to check if it was correctly updating upon opening new files.

Issues

  • 11
  • 4
  • 0
  • 15
Description From Last Updated
Not really related to this change. Raphael Kubo da Costa Raphael Kubo da Costa
Not really related to this change. Raphael Kubo da Costa Raphael Kubo da Costa
You should link against KActivities only if it was found. Raphael Kubo da Costa Raphael Kubo da Costa
Style: missing space before '{'. Raphael Kubo da Costa Raphael Kubo da Costa
Style: the '#' should be the first character in the line. Raphael Kubo da Costa Raphael Kubo da Costa
Ditto. Raphael Kubo da Costa Raphael Kubo da Costa
Style: please use the Qt/kdelibs style of 4 spaces for indentation, and add a space after the comma. And 0 ... Raphael Kubo da Costa Raphael Kubo da Costa
Please use the Qt/kdelibs coding style here. Raphael Kubo da Costa Raphael Kubo da Costa
Why don't you set the parent in the previous line? Raphael Kubo da Costa Raphael Kubo da Costa
Require current kact version: macro_optional_find_package(KActivities 6.1.0) Ivan Čukić Ivan Čukić
This here needs a include_directories(${KACTIVITIES_INCLUDE_DIRS}) Ivan Čukić Ivan Čukić
Ivan Čukić
Tomaz  Canabrava
Ivan Čukić
Tomaz  Canabrava
Ivan Čukić
Raphael Kubo da Costa
Ivan Čukić
Albert Astals Cid
Tomaz  Canabrava
Review request changed

Status: Discarded

Loading...