Fixes the autoactivation bug in folders and places panel
Review Request #106381 - Created Sept. 8, 2012 and submitted
Fixes Bug 305783 - dragging a file over a directory does not expand the dir => Bug discovered: When you drag a item onto a folder-view-item and then move it away instantly before the autoactivation event is triggered (After 750ms), the folder will be opened anyway. Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin I have divided the old review request 106271 into smaller patches. Comment #3 from review 106271: > a) We never had any complaints about this inconsistency AFAIK. Note that bug 293200 is about something else. The bug description is very difficult to understand, look at Peter's comment 3 for a summary of what we consider to be > the buggy behaviour. I think this patch should fix this buggy behaviour ;)
Thanks for the patch, and sorry for not replying earlier! Looks good, please commit (after removing the whitespace, shown in red in ReviewBoard). But as far as I can see this will fix only bug 305783, I don't see how this would prevent bug 293200 - at least what Peter describes in comment 3. Note that the mouse is still over the item ~/Images/x in the Folders Panel when the unexpected URL change in the DolphinView happens, so the "m_view->isUnderMouse()" check cannot really do anything about that, I think. Bug 293200 is probably not straigtforward to fix, we'd need to enable automatic expansion, but disable automatic item activation in the Folders Panel... But this is just the impression I got when looking at your patch. I forgot to test it at home yesterday, and here at university where I build Dolphin on top of the pre-installed KDE 4.7 using some hacks in the CMake file, the Folders Panel is the only part of Dolphin that does not work.