remove duplicated entry “Show Menu Bar” from KShortcutsDialog.
Review Request #106055 - Created Aug. 16, 2012 and discarded
remove duplicated entry “Show Menu Bar” when showing the shortcut dialog. ref. Jekyll Wu review request: #104193
seems fine on stand-alone konsole.
Well, I find it not easy for me to give a clear idea on this problem. Code wise, I prefer the patch in review 104193 because it looks straight forward and easier to follow. I have to say it takes some time for me to understand this patch. On the other hand, from average users' perspective, this solution might be better because there is no UI change. They still always have the "Show MenuBar" action at the familiar position of the context menu.
This does seem to work - I would still think that the .rc files could be tweaked to avoid the duplicate but I can't quite figure it out. Since this code is only called upon opening the shortcut menu, I guess it is OK. Jekyll?