Dolphin reports open locations to the activity manager
Review Request #105973 - Created Aug. 10, 2012 and submitted
|dolphin, kde-baseapps, plasma|
Dolphin reports open locations to the activity manager (KAMD). Reasoning behind the feature: - KAMD ranks the locations based on the time the user has spent in them - Share-Like-Connect applet can know what is open in dolphin This is an compile-time-optional feature - turned on if there is libkactivities installed. The find_package(KActivities) is located in the root CMakeLists.txt because this feature should also be implemented for Konqueror.
With SDI windows, with tabs.
Thanks for the patch! I'd say that it looks good code-wise (can't say much about the CMake stuff though, my CMake knowledge is rather limited). However, I don't think that we should keep track of the locations that a user visits in a hidden place if the user does not ask for it explicitly (I'm thinking about privacy here). Users know nowadays that they leave lots of traces both on their computer and elsewhere when visiting web pages, but I'm afraid that some users might get upset if they find out that we keep a hidden log of folders that have been opened in Dolphin, considering that Dolphin does currently not have a persistent history of visited folders. But maybe I'm too conservative here, I don't know. Can you provide some information about other info that the activity manager stores without the user's knowledge? Is there a way to disable the logging, and can the user clear the collected data easily?
OK, thanks for the explanation! If there is a way to opt-out, this can go into master from my point of view. I've noticed a possible problem though: the CMake message about kactivities in your patch says "STRONGLY_RECOMMENDED: Needed for Dolphin and Konqueror integration with activities". However, in its current state your patch will only integrate Dolphin with activities, not Konqueror. Note that DolphinViewContainer is only used by Dolphin, the Konqueror equivalent is DolphinPart. Both are wrappers for DolphinView. If you want to integrate both with activities, it might therefore be better to move your changes to DolphinView.