Thanks for the patch! Looks very good overall! Just two little ideas how you could make it even better: 1. Maybe it might be better to derive your new class FoldersItemListWidget from KFileItemListWidget rather than KStandardItemListWidget? I think that symbolic links won't be shown in italics otherwise. 2. A possibility to reduce code duplication and make the code more future-proof: rather than making KStandardItemListWidget::textColor() virtual and overriding it in derived classes, one could make a small change in KStandardItemListWidget::textColor(): replace QPalette::Text by a call to a new virtual function normalTextColor(), make KStandardItemListWidget::normalTextColor() return QPalette::Text and let it return QPalette::WindowText in the derived classes. This could have two small advantages: a) If any change in the 3 code lines that determine the color is required, we only have to change it in KStandardItemListWidget::textColor(), rather than in three different places. b) We might decide at some point that setting a custom text color for some items in the panels might be necessary. But these are just ideas - if you think that there are good reasons to not do it this way, just let me know.
Review request changed
Derive KFileItemListWidget instead of KStandardItemListWidget in FoldersItemListWidget Implemented KStandardItemListWidget::normalTextColorPalette().