Use nao:iconName for icons instead of nao:prefLabel

Reviews
Diff

- Download Diff

Information
Submitter:	Vishesh Handa
Repository:	kdelibs
Branch:
Bugs:
Depends On:
Reviewers
Groups:	nepomuk, release-team
People:	trueg

Description

The old icons will eventually be merged when I make the data migration
application for Nepomuk.

This needs to go both in kdelibs and nepomuk-core.

Testing Done

Ship it!

Ship It!

Change Summary:

@Release team: It's a minor fix, if you haven't spun the tarballs, I'll like to get it in.

Groups:

+	release-team

What's the outcome for 4.9.0 if we do not get this in?

Vishesh Handa July 30, 2012, 6:10 p.m.

Nothing drastic. Internal database stuff. Makes very little difference if it goes into 4.9 or 4.9.1 or 4.10.

Nothing user visible. I currently handle both cases in the user interface.

Albert Astals Cid July 30, 2012, 6:22 p.m.

If it does not make any huge difference, let's get it into 4.9.1 then, the less changes we made to pre-release tarballs the better (If you agree please mark this as submitted so it disappears from the release-team queue and commit it after we release on wednesday)

This review has been submitted with commit 8ccce0ff12d7310d1880a4bc100512a5134b7aa6 by Vishesh Handa to branch master.

This review has been submitted with commit 71550ae2a5bc4adb7f5609daed2efec66a34201b by Vishesh Handa to branch KDE/4.9.

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Change Summary:

Groups:

Status: Closed (submitted)