enhance performance at updating KWallet Editor Tree

Review Request #105633 - Created July 20, 2012 and discarded

Information
Martin Koller
kwalletmanager
KDE/4.9
279161, 284671
Reviewers
kdeutils
mleupold, rkcosta
I have > 340 entries in "Form Data" in the wallet. When opening the wallet editor, it takes about 9 Seconds until the tree is displayed!
I investigated the problem and found out that this is due to 2 reasons:
1.) The list of entries is checked against existing entries in the tree, which is done by linear search in the given entries list and in the tree
    which results in a quadratic complexity.
2.) unneeded duplicate dbus calls

I solved the first by using QSet for fast lookup and I reduced the second problem by avoiding a duplicate, unneeded query over dbus

  

Issues

  • 4
  • 0
  • 0
  • 4
Description From Last Updated
This is not your fault as it was that way before, but shouldn't this be translatable? I guess RTL languages ... Rolf Eike Beer Rolf Eike Beer
Well, it doesn't really refresh anymore, if you use a cache :-) The whole point of this method is to ... David Faure David Faure
All this was useful when updateEntries was called too often. Now that it's only called on actual changes, does it ... David Faure David Faure
This is the actual bugfix -- this method was wrongly assuming the item actually got renamed. But then, if it ... David Faure David Faure
Martin Koller
Rolf Eike Beer
David Faure
Raphael Kubo da Costa
Martin Koller
Review request changed

Status: Discarded

Loading...