KWallet Password Prompt Dialog In Your Face

Review Request #105628 - Created July 20, 2012 and submitted

Information
Allen Winter
kde-runtime
master
Reviewers
kde-runtime
dfaure, fredrik
This is an attempt to make the KWallet password prompt much harder to ignore or miss.

Now the prompt should always be in front of the parent window. and it should unminimize if needed, and demand attention.

[UPDATE] I'm reopening as I still think this is needed, even in 4.9.
I changed the things that gave people heartburn in my first attempt, notably removing the usertime=0 
Just using it in various scenarios.
For example, if the akonadi maildispatcher needs to open kwallet now the password prompt is always in front of kmail

[UPDATE] Without the usertime=0, you can still move kmail in front of the password prompt dialog. but at least you see the prompt first.

Issues

  • 5
  • 0
  • 0
  • 5
Description From Last Updated
from API docs: "The usage of forceActiveWindow() is meant only for pagers and similar tools, which represent direct user actions ... Martin Flöser Martin Flöser
"activeDialog()->show()" and that's (unless it's reparented) the same as ... Thomas Lübking Thomas Lübking
What's the point of demanding attention when the very next step is to force the window to be active what ... Thomas Lübking Thomas Lübking
Faking the usertime stamp is only good to cheat the focus stealing prevention, but you're invoking the tool flag ("forceActive") ... Thomas Lübking Thomas Lübking
... unminimizeWindow what's the same as activeDialog->show() Thomas Lübking Thomas Lübking
Christoph Feck
Martin Flöser
Thomas Lübking
Allen Winter
Allen Winter
Martin Flöser
Commit Hook
Commit Hook
Allen Winter
Review request changed

Status: Closed (submitted)

Loading...