Kmix Dock menu entry to open phonon settings
Review Request #105449 - Created July 5, 2012 and submitted
| Information | |
|---|---|
| Prasad Murthy | |
| kmix | |
| 4.9 | |
| https://bugs.kde.org/show_bug.cgi?id=226124 | |
| Reviewers | |
| kdemultimedia | |
| esken | |
Added dock menu entry to open phonon settings
Testing done, on clicking the menu entry the phonon settings is opened.
Issues
- 1
- 0
- 0
- 1
| Description | From | Last Updated |
|---|---|---|
| please use i18nc, makes translators happy :) http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics http://apachelog.wordpress.com/2010/08/25/i18n-semantics-cheat-sheet/ |
Harald Sitter
|
Ship It!
-
gui/kmixdockwidget.cpp (Diff revision 1) -
please use i18nc, makes translators happy :) http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics http://apachelog.wordpress.com/2010/08/25/i18n-semantics-cheat-sheet/
Review request changed
Change Summary:
Instead of creating a separate action for the context menu entry, the one which is present already in the KmixMainWindow is used.
Diff: |
Revision 2 (+2) |
|---|
This review has been submitted with commit cd0e3c8d43d2006e0070801a3a980c86b0e3f1d9 by Harald Sitter to branch master.
The patch itself looks fine. The only problem is, that I want to get rid of that menu, and not add extra functionality. That menu does not have any functionality that either the volume popup (or if that is disabled the main menu) has. - Mute - Restore - Select master channel (I have planned to move it in the popup as some kind of "Sound setup" button) It is also important for cross-desktop compatibilty, for systems that only have one kind of "Activate Tray", like Unity. See http://kmix5.wordpress.com/2012/06/26/kmixs-top-secret-features-part-1-volume-presets/ for the direction the Tray control is taking.