Add setting for konsole control drag
Review Request #105423 - Created July 3, 2012 and submitted
| Information | |
|---|---|
| Scott Kitterman | |
| konsole | |
| master | |
| 165923 | |
| Reviewers | |
| konsole | |
| hindenburg | |
Description: Add setting for control drag
Both KDE 3 and KDE 4.7 and 4.8 default to requiring click and control to drag
test in konsole. This was not required in KDE 4.0 - 4.6 and some people
prefer each method. At the moment, changing this requires recompiling
konsole, which is suboptimal. This patch adds a selection option in
the profile configuration options to change this at run time.
Addresses complaints about the fix in https://bugs.kde.org/show_bug.cgi?id=165923.
The most recent KDE I have running is 4.8.4. I first developed this patch for 4.8.4, compiled it and verified click/drag worked either with or without control based on the setting. The code required minimal adaptation to bring it up to trunk.
Jekyll Wu
Review request changed
Change Summary:
I also looked at the layout using Qt Designer and git master since the arrangement of options has changed since 4.8. I think it looks like it's in the right place.
Screenshots: |
|
|---|
Review request changed
Change Summary:
Corrected title/description. No code change.
Summary: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
-
src/EditProfileDialog.cpp (Diff revision 1) -
extra trailing space
-
src/EditProfileDialog.ui (Diff revision 1) -
This "Control Drag" is not good enough. It causes understanding problem for users and translators. The KDE3 phrase is "Require Ctrl key for drag and drop".
-
src/Profile.h (Diff revision 1) -
The name is a bit confusing. The thing is not "CtrlDrag" is enabled or not, it is that whether "Ctrl" is required for dragging selected text. So something like "CtrlRequiredForDrag" would be better, IMO.
-
src/TerminalDisplay.h (Diff revision 1) -
well, _controlDrag is no better than _ctrlDrag. If renaming is really needed, I think _ctrlRequiredForDrag or something like that would be better.
This review has been submitted with commit ed31a8b0aa6fcd45177202a60db7167e2498c80f by Kurt Hindenburg to branch master.