Fix master channel selection via kmix main window issue and fix no global master found issue

Reviews
Diff

- Download Diff

Information
Submitter:	Prasad Murthy
Repository:	kmix
Branch:	4.9
Bugs:	290177
Depends On:
Reviewers
Groups:	kdemultimedia
People:	esken

Description

This patch solves this bug https://bugs.kde.org/show_bug.cgi?id=290177
It also solves a problem with the dock icon appearing blank due to the mixer not able to find any global master. The device id returns something like "alsa_output.pci-0000_04_00.0.analog-surround-51" for 5.1 and "alsa_output.pci-0000_04_00.0.analog-stereo" for analog stereo and hence the issue.

Testing Done

Tested, able to select the master channel from the kmix main window and also the dock icon shows up correctly after changing the phonon soundcard profile example from analog stereo to analog 5.1

People:

+	esken

- Fallback to firstDevice sounds like a good idea

But I do not yet understand why it is important to create DialogSelectMaster only once? What problem does that solve, and how?

Also - I just tried to reproduce the issue and wasn't able to do so. It already works without the patch, but I know that the issue was present. Any idea how to reproduce it in the current version?

Prasad Murthy July 4, 2012, 9:42 p.m.

The idea of creating Dialogselectmaster only once is my mistake. The issue in the bug report id=290177 is, the docking is not updated after selecting the master channel via the kmix main window, this happens also in the case of changing the device profile in phonon and hence the blank icon. This is solved by updating the docking inside the function void KMixerWidget::controlsReconfiguredToplevel. I forgot to add this to the diff. I will update with a new diff with the stated changes if its ok.

Change Summary:

Dropped "creating the selectmasterdialog only once" and removed updating of the dock in slotselectmaster()in kmixmainwindow

Diff:

Revision 2 (+7 -1)

Show changes

	core/mixer.cpp
	gui/kmixerwidget.cpp

Patch was tested by QA and is working. Waiting for "ship it" approval by devs.

Bugs:

-	https://bugs.kde.org/show_bug.cgi?id=290177
+	290177

I can confirm that this patch works with Creative Sound Blaster X-FI XtremeGamer.

I tested it with Kubuntu 12.04 with KDE 4.9 from Kubuntu Beta Backports and with Kubuntu 12.10.

Without the patch KMix system tray icon changes to blank when changing audio hardware profile from Phonon settings.

With the patch KMix icon stays normal.

Thanks. The patch looks nearly fine now. Just add the bug id and review board id and a short comment in the source code (to take that into considertation for further chanages - in a year nobody will know why it had been added.).

Change Summary:

Added the required comments along with the bug id and review id

Diff:

Revision 3 (+11 -1)

Show changes

	core/mixer.cpp
	gui/kmixerwidget.cpp

This review has been submitted with commit a92a8c1c818f393833dc87d3b6eaaf669038d8c6 by Martin T. H. Sandsmark to branch master.

This review has been submitted with commit 0addbb2d9cea4bef7146ccd35527af6113664fd1 by Martin T. H. Sandsmark to branch KDE/4.9.

You have a pending review.

Review Board 2.5.15

Screenshots

Files

People:

Change Summary:

Diff:

Bugs:

Change Summary:

Diff:

Status: Closed (submitted)