add support for network zones

Review Request #105324 - Created June 22, 2012 and submitted

Information
Lukáš Tinkl
networkmanagement
nm09
Reviewers
networkmanagement
lvsouza
NetworkManager has had support for FirewallD [1] and Network Zones [2]
since [3].

This patch adds one combo box that enables to change the network zone.
This box is visible only when FirewallD is running.

[1] https://fedorahosted.org/firewalld/
[2] https://fedoraproject.org/wiki/Features/network-zones
[3] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1c0aeb457546ac5e485ca21dfe23f1a009912701

(on behalf of Jiri Popelka <jpopelka@redhat.com>)

  

Issues

  • 0
  • 6
  • 0
  • 6
Description From Last Updated
Sebastian Kügler
Lamarque Souza
Lamarque Souza
Commit Hook
Commit Hook
Lukáš Tinkl
Review request changed

Status: Closed (submitted)

Kai Uwe Broulik
Could you check if your ifdefs are properly working?
On my machine, NM happily compiles but then refuses to create any connection (dropped me back in my workplan an entire week). When I removed that patch, it worked fine again. 
  1. Do you have firewalld installed? The patch should not affect anyone without firewalld installed (like me).
  2. I have just pushed a fix for the problem. Please test and check if it works now.
  3. Hi Lamarque, 
    
    I am running PNM on openSUSE Factory (12.2) and am 100% sure that I do not have firewalld installed. However even with the current latest snapshot from GIT, I can not add any new connections. Even trying to add a wired connection through the Network Settings KCM fails with the error message "error adding connection". Existing connections can be used, but new ones cannot be saved. 
  4. I have just pushed a new fix, git pull and try again. In case of master you also must update QtNetworkManager (former libnm-qt).
  5. Hi Lamarque,
    
    After this latest update I am able to create new connections again. So I guess we can mark this little bugger as fixed. Thanks for your support.
Loading...