Fix sourceFilter to actually filter the sources in QML DataModel

Review Request #105267 - Created June 15, 2012 and submitted

Information
Viranch Mehta
kde-runtime
master
Reviewers
plasma
mart
This fixes a bug in PlasmaCore.DataModel. The DataModel does not correctly filter the sources when sourceFilter is provided.

The dataUpdated function does terminate when sourceName does not match the sourceFilter, but when it does match, all sources from the data engine are added to the said DataModel instead of checking for the sourceFilter again. This patch introduces that check.

(the patch is clearer than the description)
Tested with Battery Monitor applet when there are multiple batteries and a model is required consisting of only the battery sources from powermanagement engine.

Works as expected with the patch.
Viranch Mehta
Viranch Mehta
Marco Martin
Commit Hook
Viranch Mehta
Review request changed

Status: Closed (submitted)

Loading...