Plasmate: Add tabbox previewer
Review Request #105139 - Created June 3, 2012 and submitted
| Information | |
|---|---|
| Antonis Tsiapaliokas | |
| plasma-sdk | |
| master | |
| Reviewers | |
| kwin, plasma | |
| graesslin | |
Hello, This is the second task of my GSoC.Everything seems to work execpt from: 1)The icon of the refresh (in the tabbox previewer) is not visible. 2)I couldn't try if the refresh works...
Issues
- 2
- 8
- 0
- 10
| Description | From | Last Updated |
|---|---|---|
| I would drop the KWin specific namespaces and would properly integrate it in Plasmate |
Martin Flöser
|
|
| TabBox :-) |
Martin Flöser
|
Review request changed
Change Summary:
I have fix the typo from the refresh icon, but still the icon is not visible.....
Diff: |
Revision 2 (+791 -34) |
|---|
I have not yet tried it. From the code it looks quite ok, only comment is to drop the KWin specific namespaces.
-
previewer/tabbox/layoutpreview.h (Diff revision 2) -
I would drop the KWin specific namespaces and would properly integrate it in Plasmate
Review request changed
Change Summary:
In this patch i have remove the "KWin" namespaces and i have rename the class "LayoutPreview" to "WindowSwitcher".
Diff: |
Revision 3 (+764 -34) |
|---|
Review request changed
Change Summary:
Hello, In this patch i have made the previewer to be a standalone application. Also i have fix some issues that they have been creating because of this patch. The name of the binary is windowswitcherpreviewer. The only issue is that the refresh button of the previewer is not show, so i have put a QPushButton just for testing.
Diff: |
Revision 4 (+976 -39) |
|---|
Review request changed
Change Summary:
I have fix the issue with the refresh button. Now the user is able to refresh his tabbox qml file from plasmate and from the windowswithcerpreviewer.
Diff: |
Revision 5 (+789 -8) |
|---|
The standalone previewer is missing a Messages.sh, isn't it?
-
CMakeLists.txt (Diff revision 5) -
why do you actually keep the kwin internal name "tabbox"? Why don't you set a decent name. Be aware that the name tabbox has been set in 1999 because it's a box you use the tab key for. But today it's not like that any more or would you consider the Plasma Active's window switcher as something like "tabbox"? I really think in Plasmate we should not use historical names from KWin, but give proper names.
-
previewer/tabbox/standalone/windowswitcherpreviewer.cpp (Diff revision 5) -
should that be i18n?
-
previewer/tabbox/standalone/windowswitcherpreviewer.cpp (Diff revision 5) -
i18n missing
-
previewer/tabbox/standalone/windowswitcherpreviewer.cpp (Diff revision 5) -
?
-
previewer/tabbox/standalone/windowswitcherpreviewer.cpp (Diff revision 5) -
please don't add additional new lines, just one new line at end of file
-
previewer/tabbox/tabboxdelegate.qml (Diff revision 5) -
although if it's copied from KWin, the file is in Plasmate not part of KWin ;-)
-
previewer/tabbox/windowswitcher.cpp (Diff revision 5) -
why are here commented includes?
-
previewer/tabbox/windowswitcher.cpp (Diff revision 5) -
?
Review request changed
Change Summary:
Hello, In this patch i have remove the "Plasma/Applet" from our serviceType, because there was a regression with the plasmapkg,the plasmapkg was thinking that the tabbox was a plasmoid. So from now on, the plasmate doesn't create the project as a "hybrid"...
Diff: |
Revision 6 (+792 -11) |
|---|
Review request changed
Change Summary:
In this patch i have fix some issues. Please take a look at the preview comment of Martin
Diff: |
Revision 7 (+790 -11) |
|---|
Review request changed
Change Summary:
In this patch i have add a "Messages.sh" for windowswitcherpreviewer...
Diff: |
Revision 8 (+789 -11) |
|---|
You might consider using i18nc in future to make translator's life easier. If you want to read about it, there is something on techbase.
-
mainwindow.cpp (Diff revision 8) -
TabBox :-)
