Make area switcher usable when KDevelop runs on an appmenu-enabled system
Review Request #105116 - Created May 31, 2012 and submitted
| Information | |
|---|---|
| Aurélien Gâteau | |
| kdevplatform | |
| Reviewers | |
| kdevelop | |
| apol | |
When running on an appmenu-enabled system, one cannot add widgets in the menubar corner. This patch detects this (by checking QMenuBar::isNativeMenuBar()) and creates an action to hold the area switcher widget in this case. KDevelop itself needs a simple patch to integrate this action in its main toolbar (see https://git.reviewboard.kde.org/r/105117/ ).
Tested with and without appmenu running. With appmenu the switcher appears on the left of the main toolbar, without appmenu it appears on the right of the menubar, as before.
Issues
- 1
- 0
- 0
- 1
| Description | From | Last Updated |
|---|---|---|
| Looks like these changes should be in the UiController |
Aleix Pol Gonzalez
|
-
shell/runcontroller.cpp (Diff revision 1) -
Looks like these changes should be in the UiController
Other than that, I think it's fine and should be merged ASAP.
Review request changed
Change Summary:
Moved code to create the action from RunController to UiController.
Diff: |
Revision 2 (+33 -7) |
|---|
Looks good to me now.
This review has been submitted with commit c2bb0fa5ccb9459a940af2f02cd444efa2751c10 by Aurélien Gâteau to branch master.