Do not restore previously empty location bar URL

Review Request #104982 - Created May 18, 2012 and submitted

Information
Dawit Alemayehu
kde-baseapps
origin/KDE/4.8
270723
Reviewers
kde-baseapps
dfaure
The attached patch fixes the issue reported in the aforementioned bug report. Specifically, it stops Konqueror from restoring the location bar to the previous URL if 

a.) It was empty as in a newly created tab.
b.) The user typed in a new URL that cannot be handled by Konqueror. The URL was launched with another application.
Tested the following three scenarios:

1.) Open a new tab in Konqueror and type-in a URL it cannot handle.
2.) Open a new tab, browse to any location, and then type-in a URL Konqueror cannot handle.
3.) Open a new tab, browse to any location, clear the location bar, and then type-in a URL Konqueror cannot handle.

Results with the patch:
1.) The typed in URL remains in the location bar.
2.) The previous URL is restored in the location bar.
3.) Same as #2.


David Faure
Commit Hook
Commit Hook
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

Loading...