Actually use ExecuteBrowserPlugin in XDebugJob

Review Request #104595 - Created April 13, 2012 and discarded

Information
Dominik Schmidt
quanta
Reviewers
kdevelop, quanta
Currently the XDebugJob always uses QDesktopServices::openUrl() to open the debug page in the browser, this patch makes use of the ExecuteBrowserPlugin instance that is already present in XDebug job so the configured browser is launched.

Also it makes BrowserAppJob launch the external browser KProc with .startDetached() instead of .execute() to prevent freezing of the KDevelop GUI.


Arguments are currently ignored still, a patch for that is following

Feel free to nitpick, I haven't done any KDE coding in a while and would like to hear any suggestion for improvements :-)
It works ... ;-)

Issues

  • 3
  • 0
  • 0
  • 3
Description From Last Updated
this is unstable, it will crash as soon as the executebrowserplugin is disabled, or is that a requirement of the ... Milian Wolff Milian Wolff
is it ok to emit the result directly? or should one wait for the "started" signal (that should exist afaik)? ... Milian Wolff Milian Wolff
I don't understand this comment after the e.g. part - could you rephrase this? or give a proper example? what ... Milian Wolff Milian Wolff
Milian Wolff
Niko Sams
Kevin Funk
Dominik Schmidt
Review request changed

Status: Discarded

Change Summary:

Closing due to lack of feedback

Loading...