GlobalShortcuts Plugin for ActivityManager (kamd)

Review Request #104428 - Created March 27, 2012 and submitted

Information
makis marimpis
kactivities
KDE/4.8
265069, 273467
Reviewers
kde-baseapps, kde-runtime, plasma
ivan
(follows discarded review: 104391)

The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.

Initially, this functionality was implemented (without correct results) using KActitivities::Controller.
Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D.
Other than that, feedback is needed. 
Logged in.
Used the default shortcuts to switch activities.
It works!

Issues

  • 4
  • 22
  • 2
  • 28
Description From Last Updated
Instead of accessing this via d-bus, you can add (or I can) property with a list of activities to SharedInfo. ... Ivan Čukić Ivan Čukić
please stick to the code style, use "QString & activity" here. Lamarque Souza Lamarque Souza
In my old review I asked to do not use QDBusReply or waitForFinished, they can cause freezes in the whole ... Lamarque Souza Lamarque Souza
Maybe the slowness has nothing to do with your patch. Last weekend I was debugging a crash in Bluedevil (when ... Lamarque Souza Lamarque Souza
makis marimpis
makis marimpis
Ivan Čukić
Lamarque Souza
makis marimpis
Lamarque Souza
Lamarque Souza
makis marimpis
Lamarque Souza
Lamarque Souza
Lamarque Souza
Lamarque Souza
Lamarque Souza
Ivan Čukić
makis marimpis
Ivan Čukić
makis marimpis
makis marimpis
Commit Hook
Commit Hook
This review has been submitted with commit 7e2ef3c7f0a6584a040b4fe70e1012de9b1511d8 by Makis Marimpis to branch master.
makis marimpis
Review request changed

Status: Closed (submitted)

Loading...