Fix and cleanup of AdiumXtra styles installer
Review Request #104355 - Created March 21, 2012 and submitted
|Daniele E. Domenichelli|
AdimuXtra is currently broken, this set of patches fixes the installation of styles, I didn't try the installation of emoticons though Branch here: http://quickgit.kde.org/index.php?p=clones%2Fktp-text-ui%2Fddomenichelli%2Fktp-text-ui.git&a=shortlog&h=refs/heads/adiumxtra
Installing themes works!
|Why don't you invoke it directly but through the event loop?||Dominik Schmidt|
Can't this be done more elegantly? Fixing race conditions by just waiting a fixed time seems utterly wrong
You might wanna add yourself here ;-) Regarding my own code... sorry, for hijacking your review request: should names be enclosed in ki18n or QLatin1String? And certainly the QLatin1String is missing for my email address, so if you add yourself maybe change that too ;-)
Why don't you invoke it directly but through the event loop?
Aren't those required by the spec? Are we providing defaults when they are not around?
Thanks for taking care, it's nice to see the code is not completely abandoned! :-)
Review request changed
Fixed Dominik and David issues + another couple of leaks and a stupid cut&paste error
Revision 2 (+235 -219)