Mobile Connection Wizard: A concept of i18n of APN's list

Review Request #104349 - Created March 19, 2012 and updated

Information
Swami Dhyan Nataraj [Nikolay Shaplov]
networkmanagement
Reviewers
networkmanagement
lvsouza
This is a kind of concept how to internationalize list of APNs in mobile connection wizard.

This concept uses less CPU and more memory (through this task is not resourse critical). It create a list of apn's QVatiant map once, and then uses it all the time till the end. I thought it is better then reparse XML each time we need an APL info.

If there are ant comments, I will try to do fixes. If no, and everything is OK, I will remove all commented out code from the patch, and let's commit it :-)

  

Issues

  • 2
  • 13
  • 0
  • 15
Description From Last Updated
Forcing everyone to pass a QDomElement to this method is not a good ideia API speaking. This forces everybody to ... Lamarque Souza Lamarque Souza
The word "Default" should be the one between parentheses, that is how it is usually done. Besides, it is inconsitent ... Lamarque Souza Lamarque Souza
Lamarque Souza
Lamarque Souza

   
The word "Default" should be the one between parentheses, that is how it is usually done. Besides, it is inconsitent showing the plan name between parentheses here and not in the lines above.

Also, when creating a patch specify in reviewboard's head what branch is applies to.
Loading...