Make the 'Now listening..' presence string configurable

Review Request #104314 - Created March 17, 2012 and submitted

Information
Othmane Moustaouda
ktp-kded-module
282944
Reviewers
telepathy
Enabled the possibility for the user to set his custom 'Now listening' presence string

  

Screenshots

Issues

  • 5
  • 9
  • 0
  • 14
Description From Last Updated
Not sure QLatin1String is right. Lets say we're Italian. The default text will have been translated to: "Ora l'ascolto di ... David Edmundson David Edmundson
You might want to allow more fields here (track number, year, gender...) see http://www.mpris.org/2.1/spec/TrackList_Node.html#Mapping:Metadata_Map and http://xmms2.org/wiki/MPRIS_Metadata for the properties that ... Daniele E. Domenichelli Daniele E. Domenichelli
You don't need this check as the replace() will do nothing if there is no such string (micro-optimizaion). Martin Klapetek Martin Klapetek
Same as above Martin Klapetek Martin Klapetek
This is not right. Also if there will be even slight difference with the string, it will break horribly. You ... Martin Klapetek Martin Klapetek
David Edmundson
Dominik Schmidt
Daniele E. Domenichelli
Othmane Moustaouda
Daniele E. Domenichelli
Othmane Moustaouda
Daniele E. Domenichelli
Martin Klapetek
Othmane Moustaouda
Daniele E. Domenichelli
Martin Klapetek
Martin Klapetek
Commit Hook
Othmane Moustaouda
Review request changed

Status: Closed (submitted)

Loading...