Better tab titles in dolphin when in split view mode
Review Request #104305 - Created March 16, 2012 and discarded
Showing both locations in the tab title. See <http://forum.kde.org/brainstorm.php#idea99434_page1>
Tested with split view mode as default and opening a new tab and than changing to split mode.
Thanks for the patch! One the one hand, I think that this might be a nice idea - makes it clear at first sight what is going on in each tab when you have many tabs open :-) However, if you drag a file and drop it on a tab which shows two folder names, you don't know to which of them it will be copied/moved, which makes me think that the tab title must clearly show which folder is open in the "active view container" of that tab. Code-wise, it might be better to factor out the code which is repeated three times to a new function QString DolphinMainWindow::activeTabText() or something like that. But please wait for Peter's feedback before you start working on this (I think that Peter has some plans to move the tab-handling related code of DolphinMainWindow to a new class anyway).
Thanks for helping us to improve Dolphin! But as Frank I'm also in doubt whether this should go in at all: - The unknown dragging-target is an issue. Due to the feedback on bugs.kde.org we know that quite a few people are using the drag-feature on tabs (it was broken with Dolphin 2.0 -> not good, but at least we know now that this feature is used). Also we know that the "split-view" is enabled per default by some people, but until now it seems nobody had a trouble with the missing tab-title for the second, inactive split-view. - I personally think this improvement gets a problem as soon as more tabs than 3 or 4 tabs are shown, as the available width of a tab decreases and it is impossible to recognize even one path of the tab. So currently I'd tend to skip this change. Probably you'd like to discuss this topic with other people on forum.kde.org (in the Dolphin forum) to at least find out whether other people have a similar demand for this change or probably have some other ideas: E.g. I initially thought that using a more subtle color for the inactive view text in the tab might work, but tabs don't seem to support richtext... Also we might think about increasing the minimum tab-width to bypass the second issue.