Merge the final and fixed QML battery monitor to master.

Review Request #104226 - Created March 11, 2012 and submitted

Information
Viranch Mehta
kde-workspace
Reviewers
plasma
I fixed the QML battery monitor to be fairly usable and this diff merges it to master.
Applet and dataengine both tested and work fine.

Issues

  • 8
  • 7
  • 0
  • 15
Description From Last Updated
The word puzzle here is not translatable. You'll need to enclose a full string into i18n(), with the current code, ... Sebastian Kügler Sebastian Kügler
Word puzzles do not work for translators. This has to be done through KLocale, I don't see an option how ... Sebastian Kügler Sebastian Kügler
This guy is unnecessary, as the exact same info is already shown in the dialog. I'd prefer getting rid of ... Sebastian Kügler Sebastian Kügler
This i18n string doesn't really work. 1) This string doesn't really contain any words, so it's not really suitable for ... David Edmundson David Edmundson
showRemainingTime? Sebastian Kügler Sebastian Kügler
horizontalAlignment: Text.AlignRight Sebastian Kügler Sebastian Kügler
horizontalAlignment: Text.AlignRight Sebastian Kügler Sebastian Kügler
This looks kind bad. There should be a certain amount of padding. Vishesh Handa Vishesh Handa
Sebastian Kügler
David Edmundson
Viranch Mehta
Marco Martin
Marco Martin
Sebastian Kügler
Vishesh Handa
Marco Martin
Viranch Mehta
Sebastian Kügler
Viranch Mehta
Kai Uwe Broulik
Viranch Mehta
Viranch Mehta
Review request changed

Status: Closed (submitted)

Loading...