Moving tabs causes wrong tab to be highlighted upon reload
Review Request #103740 - Created Jan. 19, 2012 and submitted
If you open several tabs with different URLs, move one of tabs past the last tab, and either press enter or reload, the text of the wrong tab is highlighted eventhough the current active tab is correctly reloaded. The attached patch fixes the bug of the wrong tab being marked as modified.
Follow the testcase steps outlined in the bug report.
|Shouldn't this connect be removed then? Isn't there a risk that both signals get emitted in some cases?||David Faure|
Your patch fixes the bug, but it also causes a regression: If the tab contains a split view, the tab title is not highlighted any more. It seems that the purpose of the function KonqFrameTabs::tabWhereActive() is to get the tab index right for split views. Maybe a better fix would be to reorder the list m_childFrameList when a 'tabMoved(int,int)' signal is received?